fix(amazonq): fix Q panel will get stuck while signin if users have multiple window #5564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
changed the title
Will-ShaoHua
changed the title
Will-ShaoHua
commented
Apr 15, 2025
| project.messageBus.connect(toolWindow.disposable).subscribe( | ||
| QRegionProfileSelectedListener.TOPIC, | ||
| object : QRegionProfileSelectedListener { | ||
| override fun onProfileSelected(project: Project, profile: QRegionProfile?) { |
Contributor
Author
There was a problem hiding this comment.
this line project is shadowing outside AmazonQToolWindowFactory.project
Contributor
Author
There was a problem hiding this comment.
thus the following 2 lines also use the wrong project
AmazonQToolWindow.getInstance(project).disposeAndRecreate()
qPanel.setContent(AmazonQToolWindow.getInstance(project).component)
evanliu048
reviewed
Apr 15, 2025
...c/software/aws/toolkits/jetbrains/services/amazonq/profile/QRegionProfileSelectedListener.kt
Show resolved
Hide resolved
rli
approved these changes
Apr 16, 2025
evanliu048
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the
project: Projectprovided by AmazonQToolWindowFactory is shadowed byproject: Projectin RegionProfileListener.onProfileChanged(project: Project, profile: Profile), the consequence is only the project where profile change happens will get updated with the Chat UI (mynah-ui)License
I confirm that my contribution is made under the terms of the Apache 2.0 license.